Exclude system testing gems from main Gemfile#831
Merged
Conversation
bundle install surprisingly resolves dependencies for all gems in a Gemfile,
even gems in excluded groups. As a result, the "release prep" workflow failed
trying to resolve gems that are only needed when running task acceptance tests.
In Gemfile:
bolt was resolved to 4.0.0, which depends on
orchestrator_client was resolved to 0.7.2, which depends on
faraday was resolved to 1.9.0, which depends on
faraday-patron was resolved to 2.0.2, which depends on
patron
There are multiple dependency chains causing this:
bolt (5.0.1) → r10k (>= 3.10, < 5)
r10k (3.16.2) → puppet_forge (>= 2.3.0, < 4.0.0)
puppet_forge (3.2.0) → faraday (~> 1.3)
Also
beaker-abs (1.1.0) → vmfloaty (>= 1.0, < 2)
vmfloaty (1.8.1) → faraday (~> 1.5, >= 1.5.1)
This commit moves the beaker related gems to task_spec/Gemfile, similar to what
is done for acceptance/Gemfile.
It sets Gemfile to be unmanaged so we don't regress on 7246266 the next
time we `pdk update`
It updates the task_acceptance_tests GH workflow to run `bundle install` in
the `task_spec` directory.
One important change is you no longer need to set GEM_BOLT as an environment
variable **before** running "bundle install".
mhashizume
reviewed
May 7, 2026
| - gem: voxpupuli-acceptance | ||
| version: '~> 3' | ||
|
|
||
| unmanaged: true |
Contributor
There was a problem hiding this comment.
Are we going to manually update the main Gemfile instead of relying on the PDK moving forward? Or was the intent to just remove the testing-related gems?
Contributor
Author
There was a problem hiding this comment.
Once the litmus -> pdk -> r10k -> puppet_forge -> faraday 1.x dependency chain is broken, I'm hoping we can re-enable managing the Gemfile and just ignore the system_test group. Meanwhile beaker related dependencies can continue to live in acceptance/Gemfile and task_spec/Gemfile. And eventually maybe we can collapse the parallel beaker tests for manifest and tasks into a single acceptance directory/Gemfile.
mhashizume
approved these changes
May 7, 2026
mhashizume
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move system test related gems to task_spec/Gemfile similar to acceptance/Gemfile.
Update REFERENCES.md for puppetcore9-nightly.